biondizzle/vllm
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

[Test] Fix flaky race condition in test_abort_final_step (#38414)

Browse Source 
Signed-off-by: Yifan <yzong@redhat.com>
This commit is contained in:
yzong-rh
2026-03-28 05:06:56 -04:00
committed by GitHub
parent 171775f306
commit 6dad4c5722
1 changed files with 19 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
tests/v1/engine/test_abort_final_step.py
View File

@@ -259,8 +259,25 @@ async def test_abort_during_final_step(async_scheduling: bool):
# Wait for generation to complete
await gen_task
# Give the scheduler a moment to finish cleanup
await asyncio.sleep(0.1)
# Poll for the KV connector to record the finish status
timeout = 5.0
start = time.time()
captured_statuses = []
while time.time() - start < timeout:
with open(status_file) as f4:
status_lines = f4.read().strip().split("\n")
captured_statuses = [
line
for line in status_lines
if line and line.startswith("FINISHED_")
]
if captured_statuses:
break
await asyncio.sleep(0.05)
else:
raise TimeoutError(
"Timeout waiting for KV connector to record finish status."
)
# Verify we got output
assert len(outputs) > 0, "Should have received at least one output"
@@ -275,15 +292,6 @@ async def test_abort_during_final_step(async_scheduling: bool):
f"'{final_output.outputs[0].finish_reason}'. "
)
with open(status_file) as f4:
status_lines = f4.read().strip().split("\n")
# Filter for actual finish statuses (not INIT or empty lines)
captured_statuses = [
line
for line in status_lines
if line and line.startswith("FINISHED_")
]
assert len(captured_statuses) >= 1, (
f"Expected at least 1 captured finish status, got "
f"{len(captured_statuses)}. File content: {status_lines}"