[Misc] Enable async scheduling by default with spec decoding (#31998)

Signed-off-by: Nick Hill <nickhill123@gmail.com>
This commit is contained in:
Nick Hill
2026-01-09 15:09:34 -08:00
committed by GitHub
parent 97ba96fbe9
commit 3adffd5b90

View File

@@ -582,11 +582,8 @@ class VllmConfig:
)
if self.speculative_config.disable_padded_drafter_batch:
raise ValueError(
"async scheduling for EAGLE/MTP kind of speculative "
"decoding is enabled, but disable_padded_drafter_batch=True "
"disable_padded_drafter_batch=True is not supported for "
"this situation now. please set "
"disable_padded_drafter_batch=Fasle"
"Async scheduling is not compatible with "
"disable_padded_drafter_batch=True."
)
if not executor_supports_async_sched:
raise ValueError(
@@ -597,32 +594,40 @@ class VllmConfig:
elif self.scheduler_config.async_scheduling is None:
# Enable async scheduling unless there is an incompatible option.
if self.parallel_config.pipeline_parallel_size > 1:
logger.warning(
logger.warning_once(
"Async scheduling is not yet supported with "
"pipeline_parallel_size > 1 and will be disabled."
"pipeline_parallel_size > 1 and will be disabled.",
scope="local",
)
self.scheduler_config.async_scheduling = False
elif self.speculative_config is not None:
if self.speculative_config.method not in get_args(EagleModelTypes):
logger.warning(
"Async scheduling not supported with %s-based "
"speculative decoding and will be disabled.",
self.speculative_config.method,
)
else:
logger.warning(
"Async scheduling will be disabled because some features do "
"not currently work in conjunction with speculative decoding. "
"To use async scheduling with spec decoding anyway, "
"enable it explicitly via async_scheduling=True."
)
elif (
self.speculative_config is not None
and self.speculative_config.method not in get_args(EagleModelTypes)
):
logger.warning_once(
"Async scheduling not supported with %s-based "
"speculative decoding and will be disabled.",
self.speculative_config.method,
scope="local",
)
self.scheduler_config.async_scheduling = False
elif (
self.speculative_config is not None
and self.speculative_config.disable_padded_drafter_batch
):
logger.warning_once(
"Async scheduling is not compatible with "
"disable_padded_drafter_batch=True and will be disabled.",
scope="local",
)
self.scheduler_config.async_scheduling = False
elif not executor_supports_async_sched:
logger.warning(
logger.warning_once(
"Async scheduling will be disabled because it is not supported "
"with the `%s` distributed executor backend (only `mp`, `uni`, and "
"`external_launcher` are supported).",
executor_backend,
scope="local",
)
self.scheduler_config.async_scheduling = False
else: