biondizzle/vllm
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Don't fire ray compatibility webhook when PR or branch is not provided (#36088)

Browse Source 
Signed-off-by: Jeffrey Wang <jeffreywang@anyscale.com>
This commit is contained in:
Jeffrey Wang
2026-03-05 16:42:21 -08:00
committed by GitHub
parent ebed80a7c8
commit c012a8c477
1 changed files with 17 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
.buildkite/scripts/check-ray-compatibility.sh
View File

@@ -166,12 +166,19 @@ See [issue #33599](https://github.com/vllm-project/vllm/issues/33599) for contex
EOF EOF
fi fi
# Notify Slack if webhook is configured. # Notify Slack if webhook is configured and PR/branch are valid.
if [ -n "$RAY_COMPAT_SLACK_WEBHOOK_URL" ]; then if [ -n "$RAY_COMPAT_SLACK_WEBHOOK_URL" ]; then
echo ">>> Sending Slack notification" PR="${BUILDKITE_PULL_REQUEST:-}"
# Single quotes are intentional: the f-string expressions are Python, not shell. BRANCH="${BUILDKITE_BRANCH:-}"
# shellcheck disable=SC2016
PAYLOAD=$(python3 -c ' # Skip notification if PR is invalid or branch is empty
if [[ "$PR" = "false" || -z "$PR" || -z "$BRANCH" ]]; then
echo ">>> Skipping Slack notification (invalid PR or empty branch: PR=$PR, branch=$BRANCH)"
else
echo ">>> Sending Slack notification"
# Single quotes are intentional: the f-string expressions are Python, not shell.
# shellcheck disable=SC2016
PAYLOAD=$(python3 -c '
import json, os, sys import json, os, sys
pr = os.getenv("BUILDKITE_PULL_REQUEST", "N/A") pr = os.getenv("BUILDKITE_PULL_REQUEST", "N/A")
branch = os.getenv("BUILDKITE_BRANCH", "unknown") branch = os.getenv("BUILDKITE_BRANCH", "unknown")
@@ -194,10 +201,11 @@ data = {
print(json.dumps(data)) print(json.dumps(data))
') ')
HTTP_CODE=$(curl -s -o /dev/null -w "%{http_code}" -X POST "$RAY_COMPAT_SLACK_WEBHOOK_URL" \ HTTP_CODE=$(curl -s -o /dev/null -w "%{http_code}" -X POST "$RAY_COMPAT_SLACK_WEBHOOK_URL" \
-H 'Content-type: application/json' \ -H 'Content-type: application/json' \
-d "$PAYLOAD") -d "$PAYLOAD")
echo " Slack webhook response: $HTTP_CODE" echo " Slack webhook response: $HTTP_CODE"
fi
else else
echo ">>> Skipping Slack notification (RAY_COMPAT_SLACK_WEBHOOK_URL not set)" echo ">>> Skipping Slack notification (RAY_COMPAT_SLACK_WEBHOOK_URL not set)"
fi fi