biondizzle/vllm
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Deprecate best_of Sampling Parameter in anticipation for vLLM V1 (#13997)

Browse Source 
Signed-off-by: vincent-4 <vincentzhongy+githubvincent4@gmail.com>
Signed-off-by: Brayden Zhong <b8zhong@uwaterloo.ca>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Co-authored-by: Brayden Zhong <b8zhong@uwaterloo.ca>
Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
This commit is contained in:
Vincent
2025-03-05 15:22:43 -05:00
committed by GitHub
parent a32c8669ca
commit a4f1ee35d6
12 changed files with 16 additions and 88 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/v1/sample/test_sampling_params_e2e.py
View File

@@ -25,14 +25,6 @@ def test_n_gt_1(model):
assert len(outputs[0].outputs) == 3
def test_best_of(model):
"""Raise a ValueError since best_of is deprecated."""
params = SamplingParams(n=2, best_of=3)
with pytest.raises(ValueError):
_ = model.generate(PROMPT, params)
def test_penalties(model):
"""Check that we do not get errors if applied."""