biondizzle/vllm
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

[MISC][V1] Register process killing handler only in the main thread (#14380)

Browse Source 
Signed-off-by: Cody Yu <hao.yu.cody@gmail.com>
This commit is contained in:
Cody Yu
2025-03-07 22:40:06 -08:00
committed by GitHub
parent 980385f8c1
commit 9f3bc0f58c
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
vllm/v1/engine/core_client.py
View File

@@ -4,6 +4,7 @@ import asyncio
import os import os
import queue import queue
import signal import signal
import threading
import uuid import uuid
import weakref import weakref
from abc import ABC, abstractmethod from abc import ABC, abstractmethod
@@ -260,7 +261,14 @@ class MPClient(EngineCoreClient):
"down. See stack trace above for root cause issue.") "down. See stack trace above for root cause issue.")
kill_process_tree(os.getpid()) kill_process_tree(os.getpid())
if threading.current_thread() == threading.main_thread():
signal.signal(signal.SIGUSR1, sigusr1_handler) signal.signal(signal.SIGUSR1, sigusr1_handler)
else:
logger.warning("SIGUSR1 handler not installed because we are not "
"running in the main thread. In this case the "
"forked engine process may not be killed when "
"an exception is raised, and you need to handle "
"the engine process shutdown manually.")
# Serialization setup. # Serialization setup.
self.encoder = MsgpackEncoder() self.encoder = MsgpackEncoder()