From 87c98b023693dc95a49352e9e66da82ff2967571 Mon Sep 17 00:00:00 2001 From: Martin Hickey Date: Mon, 2 Mar 2026 13:23:42 +0000 Subject: [PATCH] [MyPy][BugFix] Check profiler is assigned before calling start() on it (#35505) Signed-off-by: Martin Hickey Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> --- vllm/v1/worker/gpu_worker.py | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/vllm/v1/worker/gpu_worker.py b/vllm/v1/worker/gpu_worker.py index 977d15ff2..62f0433ef 100644 --- a/vllm/v1/worker/gpu_worker.py +++ b/vllm/v1/worker/gpu_worker.py @@ -788,13 +788,14 @@ class Worker(WorkerBase): self.profiler = CudaProfilerWrapper(self.profiler_config) logger.debug("Starting CUDA profiler") else: - logger.warning("Unrecognized profiler: %s", profiler_type) - return - self.profiler.start() - else: - # Profiler already initialized. Restart profiling but keep - # the original trace name from the first initialization. - self.profiler.start() + # Config validation should prevent this code being reached + raise ValueError( + f"Invalid profiler value of {self.profiler_config.profiler}" + ) + + # If profiler already initialized, restart profiling but keep + # the original trace name from the first initialization. + self.profiler.start() else: if self.profiler is None: logger.warning("Profiler was not started, nothing to stop.")