[Docs] Improve V1 KVConnector interface documentation (#19172)
Signed-off-by: Nick Hill <nhill@redhat.com>
This commit is contained in:
@@ -101,7 +101,7 @@ class Scheduler(SchedulerInterface):
|
||||
# This is flushed at the end of each scheduling step.
|
||||
self.finished_req_ids: set[str] = set()
|
||||
|
||||
# P/D: requests in process of recving KV transfers
|
||||
# KV Connector: requests in process of async KV loading or recving
|
||||
self.finished_recving_kv_req_ids: set[str] = set()
|
||||
|
||||
# OPTIMIZATION: Cache the CachedRequestData objects to avoid creating
|
||||
@@ -822,7 +822,7 @@ class Scheduler(SchedulerInterface):
|
||||
if not stopped:
|
||||
new_running.append(request)
|
||||
|
||||
# P/D: update state for finished KV Transfers.
|
||||
# KV Connector: update state for finished KV Transfers.
|
||||
self._update_from_kv_xfer_finished(model_runner_output)
|
||||
|
||||
# Return the cached request data to the queue so they can be reused.
|
||||
@@ -969,7 +969,7 @@ class Scheduler(SchedulerInterface):
|
||||
self.kv_event_publisher.shutdown()
|
||||
|
||||
########################################################################
|
||||
# P/D Related Methods
|
||||
# KV Connector Related Methods
|
||||
########################################################################
|
||||
|
||||
def get_kv_connector(self) -> Optional[KVConnectorBase_V1]:
|
||||
@@ -992,7 +992,7 @@ class Scheduler(SchedulerInterface):
|
||||
|
||||
def _update_waiting_for_remote_kv(self, request: Request) -> bool:
|
||||
"""
|
||||
P/D: check if the request_id is finished_recving.
|
||||
KV Connector: check if the request_id is finished_recving.
|
||||
|
||||
The finished_recving_kv_req_ids list is populated
|
||||
on the previous steps()'s update_from_output based
|
||||
@@ -1029,7 +1029,7 @@ class Scheduler(SchedulerInterface):
|
||||
def _update_from_kv_xfer_finished(self,
|
||||
model_runner_output: ModelRunnerOutput):
|
||||
"""
|
||||
P/D: update the scheduler state based on the output.
|
||||
KV Connector: update the scheduler state based on the output.
|
||||
|
||||
The Worker side connectors add finished_recving and
|
||||
finished_sending reqs to the output.
|
||||
@@ -1037,7 +1037,7 @@ class Scheduler(SchedulerInterface):
|
||||
# if finished_recving: add to state so we can
|
||||
scheduler the request during the next step.
|
||||
"""
|
||||
# P/D: update recv and send status from last step.
|
||||
# KV Connector:: update recv and send status from last step.
|
||||
for req_id in (model_runner_output.finished_recving or ()):
|
||||
logger.debug("Finished recving KV transfer for request %s", req_id)
|
||||
self.finished_recving_kv_req_ids.add(req_id)
|
||||
|
||||
Reference in New Issue
Block a user