biondizzle/vllm
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

[Misc] Move disable_nccl_for_dp_synchronization init logic into VllmConfig (#30161)

Browse Source 
Signed-off-by: Nick Hill <nhill@redhat.com>
This commit is contained in:
Nick Hill
2025-12-05 20:59:04 -08:00
committed by GitHub
parent b12f4a9830
commit 4026ae31e9
2 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
vllm/config/vllm.py
View File

@@ -586,6 +586,15 @@ class VllmConfig:
else: else:
self.scheduler_config.async_scheduling = True self.scheduler_config.async_scheduling = True
if (
self.scheduler_config.async_scheduling
and not self.parallel_config.disable_nccl_for_dp_synchronization
):
logger.info(
"Disabling NCCL for DP synchronization when using async scheduling."
)
self.parallel_config.disable_nccl_for_dp_synchronization = True
from vllm.platforms import current_platform from vllm.platforms import current_platform
if ( if (

6
vllm/engine/arg_utils.py
View File

@@ -1602,12 +1602,6 @@ class EngineArgs:
model_config.skip_tokenizer_init = True model_config.skip_tokenizer_init = True
logger.info("Skipping tokenizer initialization for tokens-only mode.") logger.info("Skipping tokenizer initialization for tokens-only mode.")
if self.async_scheduling and not self.disable_nccl_for_dp_synchronization:
logger.info(
"Disabling NCCL for DP synchronization when using async scheduling."
)
self.disable_nccl_for_dp_synchronization = True
parallel_config = ParallelConfig( parallel_config = ParallelConfig(
pipeline_parallel_size=self.pipeline_parallel_size, pipeline_parallel_size=self.pipeline_parallel_size,
tensor_parallel_size=self.tensor_parallel_size, tensor_parallel_size=self.tensor_parallel_size,