biondizzle/vllm
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

[CI/Build] Replace math.isclose with pytest.approx (#18703)

Browse Source 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
This commit is contained in:
Cyrus Leung
2025-05-26 17:05:17 +08:00
committed by GitHub
parent 61a45e7a72
commit 38b13dfe78
6 changed files with 22 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tests/entrypoints/openai/correctness/test_mteb.py
View File

@@ -1,5 +1,4 @@
# SPDX-License-Identifier: Apache-2.0
import math
import os
import pytest
@@ -39,4 +38,4 @@ def test_mteb(server):
print("SentenceTransformer main score: ", st_main_score)
print("Difference: ", st_main_score - vllm_main_score)
assert math.isclose(st_main_score, vllm_main_score, rel_tol=1e-4)
assert st_main_score == pytest.approx(vllm_main_score, rel=1e-4)

8
tests/entrypoints/openai/test_score.py
View File

@@ -1,6 +1,4 @@
# SPDX-License-Identifier: Apache-2.0
import math
from typing import Any
import pytest
@@ -92,7 +90,7 @@ class TestModel:
hf_outputs = run_transformers(runner, model, text_pairs)
for i in range(len(vllm_outputs)):
assert math.isclose(hf_outputs[i], vllm_outputs[i], rel_tol=0.01)
assert hf_outputs[i] == pytest.approx(vllm_outputs[i], rel=0.01)
def test_text_1_list_text_2_list(self, server: RemoteOpenAIServer,
model: dict[str, Any], runner):
@@ -124,7 +122,7 @@ class TestModel:
hf_outputs = run_transformers(runner, model, text_pairs)
for i in range(len(vllm_outputs)):
assert math.isclose(hf_outputs[i], vllm_outputs[i], rel_tol=0.01)
assert hf_outputs[i] == pytest.approx(vllm_outputs[i], rel=0.01)
def test_text_1_str_text_2_str(self, server: RemoteOpenAIServer,
model: dict[str, Any], runner):
@@ -150,7 +148,7 @@ class TestModel:
hf_outputs = run_transformers(runner, model, text_pairs)
for i in range(len(vllm_outputs)):
assert math.isclose(hf_outputs[i], vllm_outputs[i], rel_tol=0.01)
assert hf_outputs[i] == pytest.approx(vllm_outputs[i], rel=0.01)
def test_score_max_model_len(self, server: RemoteOpenAIServer,
model: dict[str, Any]):