[Frontend] Improve Nullable kv Arg Parsing (#8525)

Signed-off-by: Alex-Brooks <Alex.Brooks@ibm.com>
This commit is contained in:
Alex Brooks
2024-09-16 22:17:32 -06:00
committed by GitHub
parent 546034b466
commit 1c1bb388e0
2 changed files with 40 additions and 8 deletions

View File

@@ -1,6 +1,8 @@
from argparse import ArgumentTypeError
import pytest
from vllm.engine.arg_utils import EngineArgs
from vllm.engine.arg_utils import EngineArgs, nullable_kvs
from vllm.utils import FlexibleArgumentParser
@@ -13,6 +15,10 @@ from vllm.utils import FlexibleArgumentParser
"image": 16,
"video": 2
}),
("Image=16, Video=2", {
"image": 16,
"video": 2
}),
])
def test_limit_mm_per_prompt_parser(arg, expected):
parser = EngineArgs.add_cli_args(FlexibleArgumentParser())
@@ -22,3 +28,15 @@ def test_limit_mm_per_prompt_parser(arg, expected):
args = parser.parse_args(["--limit-mm-per-prompt", arg])
assert args.limit_mm_per_prompt == expected
@pytest.mark.parametrize(
("arg"),
[
"image", # Missing =
"image=4,image=5", # Conflicting values
"image=video=4" # Too many = in tokenized arg
])
def test_bad_nullable_kvs(arg):
with pytest.raises(ArgumentTypeError):
nullable_kvs(arg)