Commit Graph

103 Commits

Author SHA1 Message Date
fd6b1e82d8 TMA shape diag: pure Python, no JIT 2026-05-22 21:55:03 +00:00
2f670e33d1 TMA shape diagnostic: exact setup from example9 + shape prints 2026-05-22 21:54:22 +00:00
b64227e5b6 Fix group_modes range in TMA shape diag 2026-05-22 21:53:22 +00:00
be27720cb2 Add TMA shape diagnostic 2026-05-22 21:52:51 +00:00
845ad98b22 Fix TMA indexing: 4-mode tensors, kt at mode 2 (GMEM tile dim) 2026-05-22 21:51:33 +00:00
61b0501a8b Fix test_fmha_v3_stage_c.py: 8-mode TMA indexing + O rescale (from example9) 2026-05-22 21:50:35 +00:00
328f9b0080 Test n=384 2026-05-22 21:36:22 +00:00
2da0a452d1 Quick test n=128,256 2026-05-22 21:36:00 +00:00
0d3caced47 Add: O rescale (correction_rescale) in softmax loop + remove pk from TMA/MMA 2026-05-22 21:35:39 +00:00
c47d229e6a Sweep test 2026-05-22 21:32:18 +00:00
a751b3baf7 Sweep test: n=128,256,384,512,1024 2026-05-22 21:31:15 +00:00
beaf60db5c DOCUMENT: TMA 8-mode indexing — the bug that cost us a full day. README + inline comments. 2026-05-22 21:28:58 +00:00
27116110ab Fix identity diag: same 8D TMA indexing fix 2026-05-22 21:21:52 +00:00
bb92af5b0c FIX: Use full 8D indexing for tBgK/tVgV — mode 4 is the GMEM tile dim 2026-05-22 21:21:23 +00:00
2a14c2dd18 REVERT to working baseline (n=128 cos 0.999998). Multi-tile TMA is a CuTeDSL JIT limitation. 2026-05-22 20:37:21 +00:00
1ab326f2d2 Test: use kvh.index (pipeline state) as TMA GMEM coordinate 2026-05-22 20:36:21 +00:00
7b8b022e23 SMEM counter: separate allocate_tensor instead of struct field 2026-05-22 20:35:42 +00:00
462778efcf Fix SMEM counter type: cutlass.Int32 for MemRange 2026-05-22 20:35:17 +00:00
f5c827d0b9 SMEM-backed kv_coord counter — JIT can't constant-fold SMEM reads 2026-05-22 20:34:52 +00:00
215282971c DEBUG: hardcoded Int32(1) to test if TMA can read tile 1 2026-05-22 20:34:21 +00:00
79ebe20a39 DEBUG: use Int32(kt) directly to test if coordinate matters 2026-05-22 20:34:03 +00:00
b3778896b9 Test: kv_coord = warp_idx() * 0 — force SSA from runtime value 2026-05-22 20:33:40 +00:00
1de848c5ca DEBUG: add cute.printf for kv_coord runtime value 2026-05-22 20:33:03 +00:00
587c16679c Test: Python range() instead of cutlass.range() for TMA loop 2026-05-22 20:32:44 +00:00
91230fe5e6 Test example9: drop try_acquire/pk, single loop-carried kv_coord 2026-05-22 20:32:25 +00:00
3c0451a3e5 REVERT to working example7 (n=128 cos 0.999998). Example8 TMA fix didn't work. 2026-05-22 20:28:15 +00:00
880bd9ef81 Update stage_c test to example8: SSA kv_coord + per-tile O rescale 2026-05-22 20:27:58 +00:00
c395b279d2 Clean up tests: archive superseded files, keep only essential unit tests
Kept in tests/unit/:
- test_fmha_v3.py (stages A+B)
- test_fmha_v3_diag.py (identity softmax, n=128+256)
- test_fmha_v3_stage_c.py (real softmax, n=128 cos 0.999998)
- layertest.py + cudagraph_test.py (required for every change)
- infrastructure: cache, custom_op, cutedsl, router, fp4, fused, interleave

Archived: 19 superseded unit tests + 10 root-level scratch files
Root level: only fmha_v3_stage_c_example7.py remains (now in unit/)
2026-05-22 20:25:27 +00:00
0b7ae7c969 Diag: test n=384 (3 tiles) to find crash boundary 2026-05-22 18:07:07 +00:00
640ec3e96e Diag: test all sizes 128-1024 2026-05-22 18:06:28 +00:00
02d993ecac DEBUG: disable O rescale to isolate NaN cause 2026-05-22 18:05:46 +00:00
1c3970fe58 Add NaN/inf checking to stage C test 2026-05-22 18:01:11 +00:00
d7a0fc2bc2 CRITICAL FIX: K GMEM slice (None,None,0,0) not (None,0,None,0)
K from QK MMA B-partition has GMEM iter at mode 1, NOT mode 2.
(None,0,None,0) hardcodes mode 1 to 0 → TMA always loads tile 0.
(None,None,0,0) keeps mode 1 free → correct multi-tile loading.

Proof: diag n=256 went from cos 0.711 → 0.999999 with this one change.
2026-05-22 17:59:57 +00:00
b6a2904e93 Diag: try K slice (None,None,0,0) keeping mode 1 (CUTLASS ref style) 2026-05-22 17:59:01 +00:00
01621e1520 Diag: try runtime Int32(0+0) for kv_coord with cutlass.range 2026-05-22 17:57:58 +00:00
beecc4df47 Diag: use Python range() unrolling like stage C test 2026-05-22 17:56:59 +00:00
200430bd3f Fix diagnostic test: same Int32(kt) + n_kv_tiles fixes 2026-05-22 17:56:15 +00:00
c23ebd5b57 Try cutlass.range with Int32(kt) — now n_kv_tiles is Python int 2026-05-22 17:51:25 +00:00
4a41df51c4 FIX: n_kv_tiles as Python int (s_k//128) for range() unrolling
cute.size() returns a CuTeDSL symbol, not a Python int.
range() on a symbol can't iterate — the loop never unrolls.
Now n_kv_tiles is computed in __init__ as s_k // 128 (Python int).
2026-05-22 17:50:07 +00:00
70409636f7 Option 2: Python range() with Int32(kt) for TMA GMEM coord
cutlass.range traces once - kv_coord/kt are trace-time values,
not runtime loop-carried state. Python range() fully unrolls at
trace time, emitting distinct Int32(k) constants per iteration.
Int32(1) hardcoded already proved TMA CAN load from tile 1.
2026-05-22 17:47:43 +00:00
93c28b9c29 Clean up debug prints, set kv_coord as Int32(0)
Key findings to relay to CUTLASS LLM:
- kv_coord=Int32(1) hardcode CHANGES the output (TMA CAN load from different tiles)
- kv_coord=Int32(0) + kv_coord += 1 does NOT increment at runtime
  (all multi-tile outputs identical to kv_coord=0)
- kv_coord=0 (plain Python int) also doesn't work
- Pipeline handle .count doesn't work either
- The TMA GMEM tile coordinate must be dynamic at kernel runtime,
  but CuTeDSL appears to constant-fold or not propagate the increment
2026-05-22 17:39:27 +00:00
1bba851911 DEBUG: try plain Python int kv_coord (like CUTLASS ref) 2026-05-22 17:34:30 +00:00
15b2a28d29 DEBUG: hardcode kv_coord=1 to test if TMA uses it 2026-05-22 17:32:53 +00:00
ff9ef6dcde DEBUG: try K slice (None,0,None,0) keeping mode 2 free 2026-05-22 17:30:06 +00:00
cec6f59d66 DEBUG: print tBgK/tVgV shapes before/after slice 2026-05-22 17:28:45 +00:00
8740ab5b27 Stage C: manual kv_coord + correct K GMEM slice + O rescale fence
Key fixes:
1. GMEM tile coord: manual Int32 kv_coord (not kvh.count)
2. K GMEM slice: (None,None,0,0) keeps mode 1 free (GMEM iter)
3. V GMEM slice: (None,0,None,0) keeps mode 2 free (GMEM iter)
4. Add fence_view_async_tmem_load before O rescale for visibility
2026-05-22 17:26:56 +00:00
d0626e0434 FIX: only slice GMEM tensors (SMEM already 2D from tma_partition) 2026-05-22 16:57:31 +00:00
15a2fdadbc FIX: consistent GMEM/SMEM slicing for K and V TMA partitions
Both GMEM and SMEM sides must be sliced to the same rank for cute.copy.
K (QK MMA B-partition): slice [(None,None,0,0)] keeps modes 0,1
  - mode 1 = GMEM iteration, indexed by kvh.count
V (PV MMA B-partition): slice [(None,0,None,0)] keeps modes 0,2
  - mode 2 = GMEM iteration, indexed by kvh.count
Q: only 1 tile, (None,0,None,0) hardcode is fine.
2026-05-22 16:56:38 +00:00
5c1423b2c5 FIX: keep GMEM iteration dimension FREE in TMA K/V partition slices
Root cause of multi-tile failure: (None,0,None,0) slice hardcodes the
GMEM tile dimension to 0, so TMA always loads from tile 0 regardless
of kvh.count. K from QK MMA has GMEM iter at mode 1, V from PV MMA
has it at mode 2 (different layouts: K,D,L vs D,K,L).

Fix follows CUTLASS FMHA reference:
- K: tBgK[(None,None,None,0)] + tBgK[(None, kvh.count, None)]
- V: tVgV[(None,0,None,0)] + tVgV[(None, kvh.count)]
2026-05-22 16:51:57 +00:00
018c09644b Add diagnostic test for multi-tile TMA pipeline (identity softmax) 2026-05-22 16:47:08 +00:00